Netlink tile #4049
Netlink tile #4049
Conversation
ripatel-fd
force-pushed
the
ripatel/netlink-tile
branch
from
ebeee1a to
1e5f22d
Compare
ripatel-fd
requested review from
mmcgee-jump,
nbridge-jump,
akhinvasara-jumptrading and
ptaffet-jump
src/app/fdctl/config/default.toml
Outdated
| # See `ip route show table all` | ||
| max_routes = 128 | ||
|
|
||
| # The maximum number of Ethernet neighbors (aka ARP table entries). |
There was a problem hiding this comment.
Would simplify this summary a little bit, for operators that might not know what ARP is, but have decent networking knowledge, with a bit more detail below.
ripatel-fd
force-pushed
the
ripatel/netlink-tile
branch
2 times, most recently
from
c7e6369 to
73f65cd
Compare
|
@mmcgee-jump Thanks for the review. I addressed all the code concerns. I'll need some help with documentation for the config. I suggest we update the default config file later? |
ripatel-fd
force-pushed
the
ripatel/netlink-tile
branch
3 times, most recently
from
ef2189f to
4bfee16
Compare
ripatel-fd
force-pushed
the
ripatel/netlink-tile
branch
4 times, most recently
from
f899f8b to
f34ce62
Compare
|
|
||
| /* Step 4: Update metadata */ | ||
|
|
||
| fib4->generation++; |
There was a problem hiding this comment.
Shouldn't this be:
Step 1: Indicate we are mid write
Step 2: Make default route negative
Step 3: Disable all other routes
Step 4: Update metadata (to indicate write complete)
If not, you may as well do fib4->generation += 2
There was a problem hiding this comment.
@nbridge-jump The reader doesn't care whether generation is odd or even. It just checks whether the generation is the same before and after. If it isn't, it returns a blackhole route. "Make default route negative" and "disable all other routes" have the same effect - returning a blackhole route.
There was a problem hiding this comment.
Then make it fib4->generation += 2
Adds a simple pure FIB implementation compatible with Linux
ripatel-fd
force-pushed
the
ripatel/netlink-tile
branch
from
f34ce62 to
11987e0
Compare
|
Moving to #4141 |
Relates to #692
Closes #3619